fix(rln-relay): waitFor startup, otherwise valid proofs will be marked invalid #1920
+3
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
force-pushed
the
wait-for-rln-relay-startup
branch
from
5472776 to
3bdf851
Compare
|
You can find the image built from this PR at |
56 tasks
rymnc
force-pushed
the
wait-for-rln-relay-startup
branch
from
3bdf851 to
3e8602f
Compare
alrevuelta
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
lgtm thanks!
Indeed, this should solve the problem that a node that just started (is out of sync with the contract, hence unaware of the tree and valid registrations) applies validation to messages with an outdated (or even empty tree). This would cause this node to flag valid messages as invalid (since its tree is not up to date) and this may result in descoring other peers + disconnecting for no reason.
jm-clius
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that messages are processed only after the rln-relay is ready to verify proofs, i.e updated till latest
head
Changes
s/await/waitForin chat2/wakunode2/waku_nodeIssue
Addresses a part of #1906